[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-562817452 Thanks, all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-518495040 @dongjoon-hyun could you check this pr? (I have no comment now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-518494385 > @maropu Could I open another PR to resolve this? Since this jira originally intends to support these statements with escape, I think its ok to uncomment them in this pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-517534374 plz uncoment the some existing tests for ESCAPE? https://github.com/apache/spark/blob/4e7a4cd20e2f6e19b45fee6bfd24071ce4c88dd8/sql/core/src/test/resources/sql-tests/inputs/pgSQL/strings.sql#L273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE
syntax
URL: https://github.com/apache/spark/pull/25001#issuecomment-514016800
check this query?
```
scala> sql("""select * from t9 where a like a escape '' """).show
java.lang.AssertionError: assertion failed
at scala.Predef$.assert(Predef.scala:208)
at
org.apache.spark.sql.catalyst.util.StringUtils$.escapeLikeRegex(StringUtils.scala:46)
at
org.apache.spark.sql.catalyst.util.StringUtils.escapeLikeRegex(StringUtils.scala)
at
org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown
Source)
at
org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE
syntax
URL: https://github.com/apache/spark/pull/25001#issuecomment-511803526
Also, could you check the query below?
```
scala> sql("""select * from t8 where a like b escape '"' """).show
org.apache.spark.sql.catalyst.parser.ParseException:
Invalid escape string.Escape string must be empty or one character.(line 1,
pos 25)
== SQL ==
select * from t8 where a like b escape '"'
-^^^
```
```
postgres=# select * from t8 where a like b escape '"';
a | b
---+---
(0 rows)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-511745351 yea, I'll check in a day and just a sec. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510358807 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
