[GitHub] [spark] mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier
mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier URL: https://github.com/apache/spark/pull/27178#discussion_r367014602 ## File path: dev/test-dependencies.sh ## @@ -85,10 +85,15 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do echo "Generating dependency manifest for $HADOOP_PROFILE" mkdir -p dev/pr-deps - $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly \ -| grep "Dependencies classpath:" -A 1 \ -| tail -n 1 | tr ":" "\n" | rev | cut -d "/" -f 1 | rev | sort \ -| grep -v spark > dev/pr-deps/spark-deps-$HADOOP_PROFILE + $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly | grep "Dependencies classpath:" -A 1 | tail -n 1 | tr ":" "\n" | awk -F '/' '{ Review comment: Adjusted the format. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier
mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier URL: https://github.com/apache/spark/pull/27178#discussion_r366681177 ## File path: dev/test-dependencies.sh ## @@ -85,10 +85,15 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do echo "Generating dependency manifest for $HADOOP_PROFILE" mkdir -p dev/pr-deps - $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly \ -| grep "Dependencies classpath:" -A 1 \ -| tail -n 1 | tr ":" "\n" | rev | cut -d "/" -f 1 | rev | sort \ -| grep -v spark > dev/pr-deps/spark-deps-$HADOOP_PROFILE + $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly | grep "Dependencies classpath:" -A 1 | tail -n 1 | tr ":" "\n" | awk -F '/' '{ Review comment: Added comments above the text processing part. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier
mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier URL: https://github.com/apache/spark/pull/27178#discussion_r366680997 ## File path: dev/test-dependencies.sh ## @@ -85,10 +85,15 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do echo "Generating dependency manifest for $HADOOP_PROFILE" mkdir -p dev/pr-deps - $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly \ -| grep "Dependencies classpath:" -A 1 \ -| tail -n 1 | tr ":" "\n" | rev | cut -d "/" -f 1 | rev | sort \ -| grep -v spark > dev/pr-deps/spark-deps-$HADOOP_PROFILE + $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath -pl assembly | grep "Dependencies classpath:" -A 1 | tail -n 1 | tr ":" "\n" | awk -F '/' '{ +artifact_id=$(NF-2); +version=$(NF-1); +jar_name=$(NF-0); Review comment: Modified as suggested. Thanks for catching that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier
mengCareers commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier URL: https://github.com/apache/spark/pull/27178#discussion_r366680891 ## File path: dev/deps/spark-deps-hadoop-2.6 ## @@ -153,8 +153,8 @@ objenesis/2.5.1/objenesis-2.5.1.jar okhttp/3.12.0/okhttp-3.12.0.jar okio/1.15.0/okio-1.15.0.jar opencsv/2.3/opencsv-2.3.jar -orc-core/1.5.5/orc-core-1.5.5-nohive.jar -orc-mapreduce/1.5.5/orc-mapreduce-1.5.5-nohive.jar +orc-core/1.5.5/nohive/orc-core-1.5.5-nohive.jar +orc-mapreduce/1.5.5/nohive/orc-mapreduce-1.5.5-nohive.jar Review comment: That's a good idea. Updated to the format suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org