[GitHub] [spark] merrily01 commented on a change in pull request #26088: [SPARK-29436][K8S] Support executor for selecting scheduler through scheduler name in the case of k8s multi-scheduler scenario

[GitBox]

merrily01 commented on a change in pull request #26088: [SPARK-29436][K8S] 
Support executor for selecting scheduler through scheduler name in the case of 
k8s multi-scheduler scenario
URL: https://github.com/apache/spark/pull/26088#discussion_r335268520
 
 

 ##
 File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
 ##
 @@ -216,6 +216,11 @@ private[spark] class BasicExecutorFeatureStep(
 .endSpec()
   .build()
 
+val schedulerName = kubernetesConf.get(KUBERNETES_EXECUTOR_SCHEDULER_NAME)
+if (schedulerName.nonEmpty) {
 
 Review comment:
   Resolved, thx Sean~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] merrily01 commented on a change in pull request #26088: [SPARK-29436][K8S] Support executor for selecting scheduler through scheduler name in the case of k8s multi-scheduler scenario

[GitBox]

merrily01 commented on a change in pull request #26088: [SPARK-29436][K8S] 
Support executor for selecting scheduler through scheduler name in the case of 
k8s multi-scheduler scenario
URL: https://github.com/apache/spark/pull/26088#discussion_r334726485
 
 

 ##
 File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ##
 @@ -142,6 +142,12 @@ private[spark] object Config extends Logging {
   .stringConf
   .createOptional
 
+  val KUBERNETES_EXECUTOR_SCHEDULER_NAME =
+ConfigBuilder("spark.kubernetes.executor.scheduler.name")
+  .doc("Specify the scheduler name for each executor pod")
+  .stringConf
+  .createWithDefault("")
 
 Review comment:
   Resolved, How about this ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org