[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-09 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1150993743

   And for 3.0 we have: https://github.com/apache/spark/pull/36822 (looks to me 
like there is an infrastructure problem with building it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-09 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1150797803

   Transforming with subqueries comes from 
https://github.com/apache/spark/commit/1a356858577aa13012f56fdd4b41f8ea6fe230ce 
and pruning comes from 
https://github.com/apache/spark/commit/3db8ec258c4a8438bda73c26fc7b1eb6f9d51631.
   Both of these are fairly big, and I would not just want so cherry pick them.
   That said Id did create: https://github.com/apache/spark/pull/36818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-08 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1150242302

   @MaxGekk 3.1 already does not have any transform with subqueries function, 
so I would have to backport this as well. I personally feel that this could be 
a risky endeavour not worth doing to get this fix, what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-08 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1149853529

   @MaxGekk since you closed this, should I still work on propagating this to 
3.1 and 3.0? And how should we deal with the test failures happening on 
branch-3.2? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-07 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1148633785

   Merging is blocked because of a test failure that also surfaces in 
https://github.com/apache/spark/pull/36386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-07 Thread GitBox


olaky commented on PR #36753:
URL: https://github.com/apache/spark/pull/36753#issuecomment-1148258363

   I cherry-picked 583a9c75bbb35387169d4f0cf763ef566d899954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org