[GitHub] [spark] peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] Subquery reuse across all subquery levels

2019-09-09 Thread GitBox 
peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] 
Subquery reuse across all subquery levels
URL: https://github.com/apache/spark/pull/25644#discussion_r322377100
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/InsertAdaptiveSparkPlan.scala
 ##
 @@ -41,9 +41,6 @@ case class InsertAdaptiveSparkPlan(
 
   private val conf = session.sessionState.conf
 
-  // Subquery-reuse is shared across the entire query.
-  private val subqueryCache = new TrieMap[SparkPlan, BaseSubqueryExec]()
 
 Review comment:
   No, unfortunately we can't, `stageCache` still needs it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] Subquery reuse across all subquery levels

2019-09-06 Thread GitBox 
peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] 
Subquery reuse across all subquery levels
URL: https://github.com/apache/spark/pull/25644#discussion_r321664388
 
 

 ##
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
 ##
 @@ -1238,7 +1238,10 @@ class DynamicPartitionPruningSuite
 
   val plan = df.queryExecution.executedPlan
   val countSubqueryBroadcasts =
-plan.collectInPlanAndSubqueries({ case _: SubqueryBroadcastExec => 1 
}).sum
+plan.collectInPlanAndSubqueries({
 
 Review comment:
   Ok, I've reverted the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] Subquery reuse across all subquery levels

2019-09-05 Thread GitBox 
peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] 
Subquery reuse across all subquery levels
URL: https://github.com/apache/spark/pull/25644#discussion_r321333818
 
 

 ##
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
 ##
 @@ -1238,7 +1238,10 @@ class DynamicPartitionPruningSuite
 
   val plan = df.queryExecution.executedPlan
   val countSubqueryBroadcasts =
-plan.collectInPlanAndSubqueries({ case _: SubqueryBroadcastExec => 1 
}).sum
+plan.collectInPlanAndSubqueries({
 
 Review comment:
   Ok, changed it.
   What do you think about removing `expressions.InSubquery` from 
`PlanAdaptiveSubqueries`? I don't see why it is there, but not sure that it 
should be removed in this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] Subquery reuse across all subquery levels

2019-09-05 Thread GitBox 
peter-toth commented on a change in pull request #25644: [SPARK-28940][SQL] 
Subquery reuse across all subquery levels
URL: https://github.com/apache/spark/pull/25644#discussion_r321333818
 
 

 ##
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
 ##
 @@ -1238,7 +1238,10 @@ class DynamicPartitionPruningSuite
 
   val plan = df.queryExecution.executedPlan
   val countSubqueryBroadcasts =
-plan.collectInPlanAndSubqueries({ case _: SubqueryBroadcastExec => 1 
}).sum
+plan.collectInPlanAndSubqueries({
 
 Review comment:
   ok, I changed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org