[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-30 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516705480
 
 
   It's strange. I use bash of same version for you.
   
   ```
   scala> :quit
   $ bash --version
   GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
   Copyright (C) 2007 Free Software Foundation, Inc.
   ```
   
   But the version of macOS is different. Is this the cause?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-30 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516388999
 
 
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-30 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516384594
 
 
   Lot's of flaky tests...
   
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-30 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516295386
 
 
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-29 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516261636
 
 
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-29 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-516241139
 
 
   @kiszk I think this environment variable is for developers so how about 
update `spark-env.sh.template` rather?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-29 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-515903875
 
 
   @xuanyuanking Launcher and SparkSubmit are run on different JVM process so 
we can't use `SPARK_SUBMIT_OPTS` for this purpose.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be applied Java options

2019-07-27 Thread GitBox
sarutak commented on issue #25265: [SPARK-28525][DEPLOY] Allow Launcher to be 
applied Java options
URL: https://github.com/apache/spark/pull/25265#issuecomment-515692092
 
 
   retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org