[GitHub] [spark] shivusondur commented on a change in pull request #25415: [SPARK-28390][SQL][PYTHON][TESTS] [FOLLOW-UP]Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-08-12 Thread GitBox
shivusondur commented on a change in pull request #25415: 
[SPARK-28390][SQL][PYTHON][TESTS] [FOLLOW-UP]Convert and port 
'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25415#discussion_r312885744
 
 

 ##
 File path: 
sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_having.sql
 ##
 @@ -6,7 +6,7 @@
 -- 
https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select_having.sql
 --
 -- This test file was converted from inputs/pgSQL/select_having.sql
--- TODO: We should add UDFs in GROUP BY clause when [SPARK-28445] is resolved.
+-- TODO: We should add UDFs in GROUP BY clause when [SPARK-28386] and 
[SPARK-26741] is resolved.
 
 Review comment:
   @dongjoon-hyun 
   After resolving the SPARK-28445 also, test were failing and found 
[SPARK-28386] and [SPARK-26741] are blocking it.
   
   for furher details follow 
https://github.com/apache/spark/pull/25215#issuecomment-518897609


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] shivusondur commented on a change in pull request #25415: [SPARK-28390][SQL][PYTHON][TESTS] [FOLLOW-UP]Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-08-12 Thread GitBox
shivusondur commented on a change in pull request #25415: 
[SPARK-28390][SQL][PYTHON][TESTS] [FOLLOW-UP]Convert and port 
'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25415#discussion_r312885198
 
 

 ##
 File path: 
sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_having.sql
 ##
 @@ -6,7 +6,7 @@
 -- 
https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select_having.sql
 --
 -- This test file was converted from inputs/pgSQL/select_having.sql
--- TODO: We should add UDFs in GROUP BY clause when [SPARK-28445] is resolved.
+-- TODO: We should add UDFs in GROUP BY clause when [SPARK-28386] and 
[SPARK-26741] is resolved.
 
 Review comment:
   @HyukjinKwon 
   From this 
   https://github.com/apache/spark/pull/25215#issuecomment-518897609
   I thought I need to update todo with blocking jira numbers


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org