[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r333672276
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,90 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+The `SHOW TABLES` statement returns all the tables for an optionally specified
database.
+Additionally, the output of this statement may be filtered by an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the database name from which tables are listed.
+
+ LIKE regex_pattern
+
+ Specifies the regular expression pattern that is used to filter out
unwanted tables.
+
+ Except for * and | character, the pattern works like a
regex.
Review comment:
OK, I might put back the back-ticks or quotes around special chars here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r332978571
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -38,10 +38,13 @@ SHOW TABLES [{FROM|IN} database_name] [LIKE
'regex_pattern']
LIKE 'regex_pattern'
- Specifies the regex pattern that is used to filter out unwanted tables.
-- The pattern is a regex except `*` and `|`characters
-- `*` matches 0 or more characters and `|` used to provide more
than one regex with OR condition
-- The leading and trailing blanks are trimmed in the input pattern
before processing.
+ Specifies the regular expression pattern that is used to filter out
unwanted tables.
+
+ Except `*` and `|` characters remaining characters will follow
the regular expression convention.
Review comment:
"Except for `*` and `|`, the pattern works like a regex"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r332978989
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -38,10 +38,13 @@ SHOW TABLES [{FROM|IN} database_name] [LIKE
'regex_pattern']
LIKE 'regex_pattern'
- Specifies the regex pattern that is used to filter out unwanted tables.
-- The pattern is a regex except `*` and `|`characters
-- `*` matches 0 or more characters and `|` used to provide more
than one regex with OR condition
-- The leading and trailing blanks are trimmed in the input pattern
before processing.
+ Specifies the regular expression pattern that is used to filter out
unwanted tables.
+
+ Except `*` and `|` characters remaining characters will follow
the regular expression convention.
+ `*` matches 0 or more characters and `|` used to provide more
than one regex with OR condition.
Review comment:
"`*` alone matches 0 or more characters, and `|` is used to separate
multiple different regexes, any of which can match"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r332026109
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,86 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+The `SHOW TABLES` statement returns all the tables for an optionally specified
database.
+Additionally, the output of this statement may be filtered by an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the `database` name from which tables are listed.
+
+ LIKE 'regex_pattern'
+
+ Specifies the regex pattern that is used to filter out unwanted tables.
+- The pattern is a regex except `*` and `|`characters
Review comment:
Nit: can you use an HTML unordered list? `...` etc? Or just make
this a paragraph, not bullet points.
I still think this is kind of unclear, per the last comment. "except `*`
..." should be clarified. "except that `*` and `|` have a different meaning."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#discussion_r331549488 ## File path: docs/sql-ref-syntax-aux-show-tables.md ## @@ -18,5 +18,86 @@ license: | See the License for the specific language governing permissions and limitations under the License. --- +### Description -**This page is under construction** +The `SHOW TABLES` statement returns all the tables for an optionally specified `database`. Review comment: Nit: no need to back-tick database here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r331549323
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,86 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+The `SHOW TABLES` statement returns all the tables for an optionally specified
`database`.
+Additionally, the output of this statement may be filtered by an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the `database` name from which tables are listed.
+
+ LIKE 'regex_pattern'
+
+ Specifies the regex pattern that is used to filter out unwanted tables.
+- The pattern is a regex except that `*` and `|`characters
Review comment:
"... except that `*` and `|` work differently"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#discussion_r331050942 ## File path: docs/sql-ref-syntax-aux-show-tables.md ## @@ -18,5 +18,86 @@ license: | See the License for the specific language governing permissions and limitations under the License. --- +### Description -**This page is under construction** +`SHOW TABLES` statement returns all the tables for an optionally specified `database`. Review comment: Nit: add "The" at the start. via -> by This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r329743067
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,86 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+`SHOW TABLES` statement returns all the tables for an optionally specified
`database`.
+Additionally, the output of this statement may be filtered via an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the `database` name from which tables are listed.
+
+ LIKE 'regex_pattern'
+
+ Specifies the regex pattern that is used to filter out unwanted tables.
+- Only `*` and `|` are allowed as wildcard pattern.
Review comment:
OK, your comment is consistent with the docs then. Hm, but isn't it more
accurate to say that `*` and `|` _don't_ work like in regexes? `*` matches 0 or
more characters, and `|` delimits whole regexes, which is different, but the
rest is the same. Maybe a comment more like that. "The pattern is a regex
except that `*` matches 0 or more characters by itself, and `|` may only be
used at the top level to delimit alternative regexes to match." ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r329335485
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,86 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+`SHOW TABLES` statement returns all the tables for an optionally specified
`database`.
+Additionally, the output of this statement may be filtered via an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the `database` name from which tables are listed.
+
+ LIKE 'regex_pattern'
+
+ Specifies the regex pattern that is used to filter out unwanted tables.
+- Only `*` and `|` are allowed as wildcard pattern.
Review comment:
Is it a SQL-like pattern that supports wildcards like `%`? then I'd just
call it a `pattern`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.
srowen commented on a change in pull request #25561: [SPARK-28810][DOC][SQL]
Document SHOW TABLES in SQL Reference.
URL: https://github.com/apache/spark/pull/25561#discussion_r329314969
##
File path: docs/sql-ref-syntax-aux-show-tables.md
##
@@ -18,5 +18,86 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
+### Description
-**This page is under construction**
+`SHOW TABLES` statement returns all the tables for an optionally specified
`database`.
+Additionally, the output of this statement may be filtered via an optional
matching
+pattern. If no database is specified then the tables are returned from the
+current database.
+
+### Syntax
+{% highlight sql %}
+SHOW TABLES [{FROM|IN} database_name] [LIKE 'regex_pattern']
+{% endhighlight %}
+
+### Parameters
+
+ {FROM|IN} database_name
+
+ Specifies the `database` name from which tables are listed.
+
+ LIKE 'regex_pattern'
+
+ Specifies the regex pattern that is used to filter out unwanted tables.
+- Only `*` and `|` are allowed as wildcard pattern.
Review comment:
`|` isn't a wildcard pattern, so I wouldn't imply it is.
Is it really treated as a full regex otherwise? if not, I wouldn't call it a
regex unless it is generally called this in other similar references.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
