srowen commented on pull request #35134: URL: https://github.com/apache/spark/pull/35134#issuecomment-1008048012
These are good changes, but, these are changes to copied Hive code. We can 'fix' it but might introduce tiny differences and merge conflicts if we update the Hive code. Are there any instances in the Spark code (not in org.apache.hive)? those would be fine to change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org