[GitHub] [spark] sunchao commented on a change in pull request #30597: [SPARK-33652][SQL] DSv2: DeleteFrom should refresh cache

[GitBox]

sunchao commented on a change in pull request #30597:
URL: https://github.com/apache/spark/pull/30597#discussion_r536467268



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##
@@ -111,16 +111,16 @@ case class DataSourceV2Relation(
  * plan. This ensures that the stats that are used by the optimizer account 
for the filters and
  * projection that will be pushed down.
  *
- * @param table a DSv2 [[Table]]
+ * @param v2Relation a [[DataSourceV2Relation]]
  * @param scan a DSv2 [[Scan]]
  * @param output the output attributes of this relation
  */
 case class DataSourceV2ScanRelation(
-table: Table,
+v2Relation: DataSourceV2Relation,

Review comment:
   Sure. Done.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] sunchao commented on a change in pull request #30597: [SPARK-33652][SQL] DSv2: DeleteFrom should refresh cache

[GitBox]

sunchao commented on a change in pull request #30597:
URL: https://github.com/apache/spark/pull/30597#discussion_r535809636



##
File path: 
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -1841,6 +1841,22 @@ class DataSourceV2SQLSuite
 }
   }
 
+  test("DeleteFrom: should refresh caches referencing the table") {

Review comment:
   Good idea. Will do.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org