[GitHub] [spark] tanelk commented on pull request #31677: [SPARK-34565][SQL] Collapse Window nodes with Project between them

2021-06-09 Thread GitBox


tanelk commented on pull request #31677:
URL: https://github.com/apache/spark/pull/31677#issuecomment-858317298


   This and a very similar PR #31980 have been approved for a while now. 
@maropu , could you take another look, maybe we can merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] tanelk commented on pull request #31677: [SPARK-34565][SQL] Collapse Window nodes with Project between them

2021-05-24 Thread GitBox


tanelk commented on pull request #31677:
URL: https://github.com/apache/spark/pull/31677#issuecomment-847125608


   @HyukjinKwon, this has few aprovals, but is there anyone else you would like 
to take a look at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] tanelk commented on pull request #31677: [SPARK-34565][SQL] Collapse Window nodes with Project between them

2021-03-17 Thread GitBox


tanelk commented on pull request #31677:
URL: https://github.com/apache/spark/pull/31677#issuecomment-800864784


   @HyukjinKwon, this has been aproved for a while now, any change, that we can 
merge this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org