[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-546161691 > shall we name it `REPARTITION_BY_RANGE`? I'm not sure how hints are named in the mainstream databases. It reminds me. Fix it to keep consistent with join hints style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethink it again? > `expects UnresolvedAttribute type` How about `Repartition hint parameter should be columns but was $errExprs` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethink it again? > `expects UnresolvedAttribute type` How about `Repartition hint parameter should be some columns but was $errExprs` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethink it again? > `expects UnresolvedAttribute type` How about `expects some columns` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
