[GitHub] [spark] vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog.
vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog. URL: https://github.com/apache/spark/pull/24732#issuecomment-497122483 It's such a small change that it shouldn't affect anybody. (For comparison, the default value on sockets not created from Java is 128.) In fact it makes it clearer that Spark is setting a value explicitly instead of relying on the JVM default (for those who know that detail). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog.
vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog. URL: https://github.com/apache/spark/pull/24732#issuecomment-573761584 Sorry you ran into problems, but I'm curious about this: > In our set up we had the default JVM value overridden How did you do that? I just looked at the source again and it's hardcoded to 50. Which is why in my mind this wouldn't cause any problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog.
vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog. URL: https://github.com/apache/spark/pull/24732#issuecomment-574885029 Ah, in that case it might be a better idea to revert the configuration change. Want to open a PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog.
vanzin commented on issue #24732: [SPARK-27868][core] Better default value and documentation for socket server backlog. URL: https://github.com/apache/spark/pull/24732#issuecomment-574898859 I think that since Netty makes an effort to look at the OS configuration to define the default value, that it makes more sense to not have Spark override that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
