[GitHub] [spark] viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix: REPARTITION hint does not work with order by
viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix:
REPARTITION hint does not work with order by
URL: https://github.com/apache/spark/pull/26946#discussion_r360760641
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##
@@ -55,6 +55,8 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
child
case (child, BroadcastDistribution(mode)) =>
BroadcastExchangeExec(mode, child)
+ case (ShuffleExchangeExec(partitioning, child, _), distribution:
OrderedDistribution) =>
+
ShuffleExchangeExec(distribution.createPartitioning(partitioning.numPartitions),
child)
Review comment:
I just tried few possible cases, but can not have a concrete case like this.
Maybe this is the only case possibly. So I think this should be fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix: REPARTITION hint does not work with order by
viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix:
REPARTITION hint does not work with order by
URL: https://github.com/apache/spark/pull/26946#discussion_r360760641
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##
@@ -55,6 +55,8 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
child
case (child, BroadcastDistribution(mode)) =>
BroadcastExchangeExec(mode, child)
+ case (ShuffleExchangeExec(partitioning, child, _), distribution:
OrderedDistribution) =>
+
ShuffleExchangeExec(distribution.createPartitioning(partitioning.numPartitions),
child)
Review comment:
I just tried few possible cases, but can not have a concrete case like this.
Maybe this is the only case possibly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix: REPARTITION hint does not work with order by
viirya commented on a change in pull request #26946: [SPARK-30036][SQL] Fix:
REPARTITION hint does not work with order by
URL: https://github.com/apache/spark/pull/26946#discussion_r360673289
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##
@@ -55,6 +55,8 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
child
case (child, BroadcastDistribution(mode)) =>
BroadcastExchangeExec(mode, child)
+ case (ShuffleExchangeExec(partitioning, child, _), distribution:
OrderedDistribution) =>
+
ShuffleExchangeExec(distribution.createPartitioning(partitioning.numPartitions),
child)
Review comment:
This considers a special case for OrderedDistribution. Generally, if
ShuffleExchangeExec is followed by any unsatisfying distribution , we should
always trim the ShuffleExchangeExec and apply the partitioning of distribution.
Don't we?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
