[GitHub] [spark] viirya commented on a change in pull request #27772: [SPARK-31019][SQL] make it clear that people can deduplicate map keys
viirya commented on a change in pull request #27772: [SPARK-31019][SQL] make it clear that people can deduplicate map keys URL: https://github.com/apache/spark/pull/27772#discussion_r387252151 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2435,17 +2450,6 @@ object SQLConf { .booleanConf .createWithDefault(false) - val LEGACY_ALLOW_DUPLICATED_MAP_KEY = Review comment: We need to update sql-migration-guide doc too. We already documented `spark.sql.legacy.allowDuplicatedMapKeys` there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27772: [SPARK-31019][SQL] make it clear that people can deduplicate map keys
viirya commented on a change in pull request #27772: [SPARK-31019][SQL] make it clear that people can deduplicate map keys URL: https://github.com/apache/spark/pull/27772#discussion_r387252151 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2435,17 +2450,6 @@ object SQLConf { .booleanConf .createWithDefault(false) - val LEGACY_ALLOW_DUPLICATED_MAP_KEY = Review comment: We need to update sql-migration-guide doc too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org