[GitHub] [spark] viirya edited a comment on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox


viirya edited a comment on pull request #32586:
URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300


   Sorry I misread the code, looks like we add parent expression first into the 
map and traverse to its children expressions. Let me put it in draft first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] viirya edited a comment on pull request #32586: [SPARK-35439][SQL] Use LinkedHashMap to guarantee traversing with the order they were inserted

2021-05-18 Thread GitBox


viirya edited a comment on pull request #32586:
URL: https://github.com/apache/spark/pull/32586#issuecomment-843733300


   Sorry I misread the code, looks like we add parent expression first 
into the map and traverse to its children expressions. Let me put it in draft 
first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org