[GitHub] [spark] wangyum commented on pull request #30408: [SPARK-33477][SQL] Hive Metastore support filter by date type

2021-01-02 Thread GitBox


wangyum commented on pull request #30408:
URL: https://github.com/apache/spark/pull/30408#issuecomment-753561772


   > @wangyum Could you add more test cases to check the NULL handling cases? 
For example,
   > 
   > * Include NULL values in the data set
   > * Include NULL values in the predicates
   > * Include null-safe equals
   > 
   > Please check 
https://spark.apache.org/docs/3.0.1/sql-ref-null-semantics.html#comp-operators
   
   OK



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on pull request #30408: [SPARK-33477][SQL] Hive Metastore support filter by date type

2020-11-24 Thread GitBox


wangyum commented on pull request #30408:
URL: https://github.com/apache/spark/pull/30408#issuecomment-733515064


   retest this please.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org