[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin
wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-650014523 Hi, @dongjoon-hyun , I'm sorry , the result of maven compile seems OK after I change a computer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin
wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646469772 Update PR, and leave the shade plugin in. The test jar is need if I want to compile some other spark modules(eg. mllib ) individually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin
wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646414088 Hi @srowen, I have compared the compilation results with and without shade plugin. Their result classes are the same. So I don't think we need to keep shade plugin anymore. ``` ➜ tmp ls -al shade total 11864 drwxr-xr-x 21 wankun staff 672 6 19 11:11 . drwxr-xr-x 9 wankun staff 288 6 19 11:15 .. -rw-r--r-- 1 wankun staff 30 6 19 11:11 .plxarc drwxr-xr-x 4 wankun staff 128 6 19 11:11 analysis drwxr-xr-x 3 wankun staff 96 6 19 11:11 antrun -rw-r--r-- 1 wankun staff 2103 6 19 11:11 checkstyle-cachefile -rw-r--r-- 1 wankun staff 8225 6 19 11:11 checkstyle-checker.xml -rw-r--r-- 1 wankun staff 2133 6 19 11:11 checkstyle-output.xml drwxr-xr-x 3 wankun staff 96 6 19 11:11 maven-archiver drwxr-xr-x 3 wankun staff 96 6 19 11:11 maven-shared-archive-resources -rw-r--r-- 1 wankun staff 849617 6 19 11:11 original-spark-streaming_2.12-3.0.0-tests.jar -rw-r--r-- 1 wankun staff 1129042 6 19 11:11 original-spark-streaming_2.12-3.0.0.jar drwxr-xr-x 4 wankun staff 128 6 19 11:11 scala-2.12 -rw-r--r-- 1 wankun staff 91 6 19 11:11 scalastyle-output.xml drwxr-xr-x 3 wankun staff 96 6 19 11:11 site -rw-r--r-- 1 wankun staff 1640857 6 19 11:11 spark-streaming_2.12-3.0.0-javadoc.jar -rw-r--r-- 1 wankun staff 252544 6 19 11:11 spark-streaming_2.12-3.0.0-sources.jar -rw-r--r-- 1 wankun staff 170013 6 19 11:11 spark-streaming_2.12-3.0.0-test-sources.jar -rw-r--r-- 1 wankun staff 854204 6 19 11:11 spark-streaming_2.12-3.0.0-tests.jar -rw-r--r-- 1 wankun staff 1137942 6 19 11:11 spark-streaming_2.12-3.0.0.jar drwxr-xr-x 2 wankun staff 64 6 19 11:11 tmp ➜ tmp ls -al without_shade total 10192 drwxr-xr-x 20 wankun staff 640 6 19 11:13 . drwxr-xr-x 9 wankun staff 288 6 19 11:15 .. -rw-r--r-- 1 wankun staff 30 6 19 11:13 .plxarc drwxr-xr-x 4 wankun staff 128 6 19 11:13 analysis drwxr-xr-x 3 wankun staff 96 6 19 11:13 antrun -rw-r--r-- 1 wankun staff 2103 6 19 11:13 checkstyle-cachefile -rw-r--r-- 1 wankun staff 8225 6 19 11:13 checkstyle-checker.xml -rw-r--r-- 1 wankun staff 2133 6 19 11:13 checkstyle-output.xml drwxr-xr-x 3 wankun staff 96 6 19 11:13 maven-archiver drwxr-xr-x 3 wankun staff 96 6 19 11:13 maven-shared-archive-resources -rw-r--r-- 1 wankun staff 1129002 6 19 11:13 original-spark-streaming_2.12-3.0.0.jar drwxr-xr-x 4 wankun staff 128 6 19 11:13 scala-2.12 -rw-r--r-- 1 wankun staff 91 6 19 11:13 scalastyle-output.xml drwxr-xr-x 3 wankun staff 96 6 19 11:13 site -rw-r--r-- 1 wankun staff 1640857 6 19 11:13 spark-streaming_2.12-3.0.0-javadoc.jar -rw-r--r-- 1 wankun staff 252504 6 19 11:13 spark-streaming_2.12-3.0.0-sources.jar -rw-r--r-- 1 wankun staff 169973 6 19 11:13 spark-streaming_2.12-3.0.0-test-sources.jar -rw-r--r-- 1 wankun staff 849577 6 19 11:13 spark-streaming_2.12-3.0.0-tests.jar -rw-r--r-- 1 wankun staff 1137902 6 19 11:13 spark-streaming_2.12-3.0.0.jar drwxr-xr-x 2 wankun staff 64 6 19 11:13 tmp ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
