[GitHub] [spark] xuanyuanking commented on pull request #30148: [SPARK-33244][SQL] Unify the code paths for spark.table and spark.read.table

2020-11-11 Thread GitBox 


xuanyuanking commented on pull request #30148:
URL: https://github.com/apache/spark/pull/30148#issuecomment-725304354


   Thanks for the review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] xuanyuanking commented on pull request #30148: [SPARK-33244][SQL] Unify the code paths for spark.table and spark.read.table

2020-11-03 Thread GitBox 


xuanyuanking commented on pull request #30148:
URL: https://github.com/apache/spark/pull/30148#issuecomment-720391093


   Sorry for the late reply, and thanks for the discussion.
   
   ```
   cc. @cloud-fan as I remember we had a related discussion in other PR.
   ```
   Find the discussion and link it here: 
https://github.com/apache/spark/pull/29756#discussion_r490177455
   
   ```
   Let's fix it to remove any confusion then - let's ensure both 
spark.read.table and spark.table can't deal with streaming table (even it is 
from temp view) so end users need to deal with spark.readStream.table.
   ```
   Sure, will be done in this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org