[GitHub] [spark] xuanyuanking commented on pull request #32702: [SPARK-35565][SS] Add config for ignoring metadata directory of FileStreamSink

2021-06-18 Thread GitBox


xuanyuanking commented on pull request #32702:
URL: https://github.com/apache/spark/pull/32702#issuecomment-864357220


   Thanks @viirya !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] xuanyuanking commented on pull request #32702: [SPARK-35565][SS] Add config for ignoring metadata directory of FileStreamSink

2021-06-04 Thread GitBox


xuanyuanking commented on pull request #32702:
URL: https://github.com/apache/spark/pull/32702#issuecomment-854835227


   Agree. Adding a config also has one benefit is that the existing application 
can avoid changing the code. But we'll still avoid adding more and more configs 
later as @HeartSaVioR suggested. There's indeed too much configs to control the 
behaviors :joy:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org