[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-563882462 The dev mailing list seems remains silent about this, I just found that hive also has involved this feature since its 3.0.0 release. How about we make this possible? cc: @maropu @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-563304737 https://issues.apache.org/jira/browse/HIVE-16764 hive supports numeric since 3.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-562086114 thanks, @HyukjinKwon for your suggestion. I have drafted a proposal here. http://apache-spark-developers-list.1001551.n3.nabble.com/PROPOSAL-Support-ANSI-type-real-numeric-as-synonyms-for-float-decimal-td28475.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-554944420 > > DEC is equivalent to DECIMAL. INT is equivalent to INTEGER. > > These two we can implement Int/Integer is already supported, I'll make a separate pr to support `dec` and leave the current one for further discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-554642845 > CHAR is equivalent to CHARACTER. DEC is equivalent to DECIMAL. INT is equivalent to INTEGER. VARCHAR is equivalent to CHARACTER VARYING. ... According to SQL standard, do we need DEC which is short for DECIMAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-554640831 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-554215516 that pr seems to be raised before this ticket https://issues.apache.org/jira/browse/SPARK-27764, now we are enhancing ansi support and PostgresSQL feature parity, maybe have enough reason to support these types. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal
yaooqinn commented on issue #26537: [SPARK-29587][SQL] Support SQL Standard type real as float(4) numeric as decimal URL: https://github.com/apache/spark/pull/26537#issuecomment-554200525 cc @cloud-fan @maropu @HyukjinKwon, thanks for reviewing in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
