[GitHub] [spark] yaooqinn commented on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE
yaooqinn commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657346567 the test case for listing all timezones is removed because it varies from different JDKs. The interval is supported and also some extensions were made too 1) offset range is [-18, +18] in spark which is bigger than ansi's, 2) the second part is supported in Spark, e.g. +14:14:14, while ansi only indicates hours-minutes, 3) multi value-units interval is much common than unit-to-unit ones, so this interval form is supported too. cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE
yaooqinn commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-656672874 > > because it has to be qualified with interval qualifier HOUR TO MINUTE which is not fully supported in Spark now. > > `HOUR TO MINUTE` is a supported interval literal syntax, isn't it? OK, I will add fully support then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29064: [SPARK-32272][SQL] Add and extend SQL standard command SET TIME ZONE
yaooqinn commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-656625284 cc @cloud-fan @maropu @dongjoon-hyun thanks for reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
