[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1695832483 The example in PR desc prints too many infrequently used characters I apologize for any confusion caused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674:
URL: https://github.com/apache/spark/pull/42674#issuecomment-1695803037
https://github.com/apache/spark/pull/42674/files#diff-525465a6c6c1382bf8165da748522ec2387581ebd397fe25f5aa72107a45752aR119-R120,
All the characters are here.
In the PR description, I described the issue
> Previously, all the error details and some of the error summaries, such as
the Task list on the stage page, did not call escapeHtml4. The rest of the
error summaries, such as Job list, Stage list, Query list, etc., will do an
extra escapeHtml4 that is unnecessary.
For example, if we initially throw a RuntimeException("<"). Those places
that did not call escapeHtml4 display the message `java.lang.RuntimeException:
<`, while the others that call escapeHtml4 show `java.lang.RuntimeException:
`. You can also view the picture below with spark 3.4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1695053749 thanks @srowen @gengliangwang @sarutak @HyukjinKwon @dongjoon-hyun, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1694942009 > The second example just shows <> which can't the 'right' version of whatever this is It's the source code version, the rendered HTML. > What happened to the garbled text There is no garbled text, and these are all Latin-1. FYI, https://github.com/apache/commons-text/blob/master/src/main/java/org/apache/commons/text/translate/EntityArrays.java#L39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1694869333 Hi @srowen, it actually removes double-escaping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1693602186 Thank you, @dongjoon-hyun. I have made the necessary updates to the PR based on your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1693487193 cc @sarutak @HyukjinKwon @cloud-fan @dongjoon-hyun, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
