[GitHub] [spark] zero323 commented on pull request #35124: [WIP][SPARK-37398][PYTHON] Inline type hints for python/pyspark/ml/classification.py
zero323 commented on pull request #35124: URL: https://github.com/apache/spark/pull/35124#issuecomment-1043151847 On a side note ‒ if you don't yet, please make sure that you run at least [`dev/lint-python`](https://github.com/apache/spark/blob/master/dev/lint-python) (it requires `mypy`, `black`, `flake8`) before pushing your work ‒ it can detect a lot of errors right away, takes almost no time and doesn't require up-to-date Java build. It is also a good idea to run `python/run-tests.py --modules pyspark-ml`, but you'll have to [build JVM components](https://spark.apache.org/docs/latest/building-spark.html) for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35124: [WIP][SPARK-37398][PYTHON] Inline type hints for python/pyspark/ml/classification.py
zero323 commented on pull request #35124: URL: https://github.com/apache/spark/pull/35124#issuecomment-1059871429 Gentle ping @javierivanov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35124: [WIP][SPARK-37398][PYTHON] Inline type hints for python/pyspark/ml/classification.py
zero323 commented on pull request #35124: URL: https://github.com/apache/spark/pull/35124#issuecomment-1007376991 Thanks @javierivanov. Let's revisit this after all prerequisites are done (core for starters, but there are also internal dependencies that have to be followed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35124: [WIP][SPARK-37398][PYTHON] Inline type hints for python/pyspark/ml/classification.py
zero323 commented on pull request #35124: URL: https://github.com/apache/spark/pull/35124#issuecomment-1007376991 Thanks @javierivanov. Let's revisit this after all prerequisites are done (core for starters, but there are also internal dependencies that have to be followed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35124: [WIP][SPARK-37398][PYTHON] Inline type hints for python/pyspark/ml/classification.py
zero323 commented on pull request #35124: URL: https://github.com/apache/spark/pull/35124#issuecomment-1030824756 As of today, all the prerequisites for this PR, with exception to SPARK-37416 / #35399 are resolved, so if you're still interested working on this, I'd recommend squashing your work so far and rebasing to the default branch. To address any missing methods you can temporarily patch `ml.wrapper` (see for example https://github.com/apache/spark/pull/35403/files). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
