[GitHub] [spark-connect-go] arnarpall commented on pull request #12: [SPARK-44141] Removed need to have buf preinstalled

2023-09-15 Thread via GitHub


arnarpall commented on PR #12:
URL: https://github.com/apache/spark-connect-go/pull/12#issuecomment-1721362325

   I seems like not all the changes to the workflow are not being reflected 
properly.
   
   The current failure.
   Output from the `internal/generated.out` target is for the run
   ```
   >> BUILD, output = internal/generated.outbuf generate --debug -vvv
   bash: line 1: buf: command not found
   ```
   
   However this is what we should be expecting 
   ```
   >> BUILD, output = internal/generated.outGO111MODULE=on go run 
github.com/bufbuild/buf/cmd/buf@v1.26.1 generate --debug -vvv
   ```
   Here instead of calling the buf binary directly we expect it to be wrapped 
in a `go run` statement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark-connect-go] arnarpall commented on pull request #12: [SPARK-44141] Removed need to have buf preinstalled

2023-09-14 Thread via GitHub


arnarpall commented on PR #12:
URL: https://github.com/apache/spark-connect-go/pull/12#issuecomment-1719605583

   @HyukjinKwon  hey hey. I finally managed to get back to this PR, could you 
perhaps approve the workflow for me ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org