[GitHub] deshanxiao commented on a change in pull request #23668: [SPARK-26660][FOLLOWUP] Add warning logs when broadcasting large task binary

2019-01-27 Thread GitBox 
deshanxiao commented on a change in pull request #23668: 
[SPARK-26660][FOLLOWUP] Add warning logs when broadcasting large task binary
URL: https://github.com/apache/spark/pull/23668#discussion_r251289378
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
 ##
 @@ -1162,7 +1162,7 @@ private[spark] class DAGScheduler(
 partitions = stage.rdd.partitions
   }
 
-  if (taskBinaryBytes.length * 1000 > TaskSetManager.TASK_SIZE_TO_WARN_KB) 
{
+  if (taskBinaryBytes.length > TaskSetManager.TASK_SIZE_TO_WARN_KB * 1000) 
{
 
 Review comment:
   More precise I think would be 1024, is it right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] deshanxiao commented on a change in pull request #23668: [SPARK-26660][FOLLOWUP] Add warning logs when broadcasting large task binary

2019-01-27 Thread GitBox 
deshanxiao commented on a change in pull request #23668: 
[SPARK-26660][FOLLOWUP] Add warning logs when broadcasting large task binary
URL: https://github.com/apache/spark/pull/23668#discussion_r251289378
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
 ##
 @@ -1162,7 +1162,7 @@ private[spark] class DAGScheduler(
 partitions = stage.rdd.partitions
   }
 
-  if (taskBinaryBytes.length * 1000 > TaskSetManager.TASK_SIZE_TO_WARN_KB) 
{
+  if (taskBinaryBytes.length > TaskSetManager.TASK_SIZE_TO_WARN_KB * 1000) 
{
 
 Review comment:
   More precisely I think would be 1024, is it right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org