[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 Thanks @JoshRosen, @brkyvz and @vanzin! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13428 Merged to master and branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13428 LGTM; I'll merge when I get home tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 ping @JoshRosen, I think this should be good to go now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 Thanks for the review @JoshRosen, I made the requested changes and tested it out once more. I think it is low risk because it is pretty well isolated to this particular issue and only improves on how it was before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63812/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #63812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63812/consoleFull)** for PR 13428 at commit [`df1ac92`](https://github.com/apache/spark/commit/df1ac92b6ae73eaf05b4f4b3d9a4a9178d724f05). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #63812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63812/consoleFull)** for PR 13428 at commit [`df1ac92`](https://github.com/apache/spark/commit/df1ac92b6ae73eaf05b4f4b3d9a4a9178d724f05). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13428 Modulo the minor review comments already left on this PR, this looks good to me as well. Is there any risk in putting this into 2.0.1 / 2.1.0? Will this change the resolution behavior for any cases which didn't fail before this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/13428 Two suggestions, otherwise I'm not familiar enough with Ivy - I'll trust you guys to know what you're doing. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 ping @JoshRosen , would you mind taking a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62673/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #62673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62673/consoleFull)** for PR 13428 at commit [`b87e0c9`](https://github.com/apache/spark/commit/b87e0c95c140389148a2140962709fd37d61d427). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #62673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62673/consoleFull)** for PR 13428 at commit [`b87e0c9`](https://github.com/apache/spark/commit/b87e0c95c140389148a2140962709fd37d61d427). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/13428 LGTM. @JoshRosen Can we merge this to 2.0.0? This is a very nice fix that I couldn't figure out for a long time. It's amazing because it's so simple --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 Hi @brkyvz , did you ever get a chance to try this out and see if it works for you? I imagine you probably have been pretty slammed with the 2.0 release.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59786/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #59786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59786/consoleFull)** for PR 13428 at commit [`b87e0c9`](https://github.com/apache/spark/commit/b87e0c95c140389148a2140962709fd37d61d427). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59779/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #59779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59779/consoleFull)** for PR 13428 at commit [`ece86f1`](https://github.com/apache/spark/commit/ece86f1e463707433ccdc34cb5ed10a506da80cb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #59786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59786/consoleFull)** for PR 13428 at commit [`b87e0c9`](https://github.com/apache/spark/commit/b87e0c95c140389148a2140962709fd37d61d427). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 Haha, no problem, I'll take a virtual high-five :P I agree `default(runtime)` does make more sense, I'll change that up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/13428 @BryanCutler Am I dreaming or is this for real. I've been trying to solve this issue for a very long time. I honestly want to give you a high five now :) `default(runtime)` makes sense to me. Some jars don't have sources, javadocs, etc. and I wouldn't want things to fail in that case. Pulling in all test dependencies is also useless. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13428 Using the wildcard for the fallback conf "default(*)" has the side effect of resolving transitive dependencies from all scopes - so it will grab test jars, etc Would it be more appropriate to use "default(runtime)" instead? It has the tradeoff of being less flexible but I tested using spark-csv publishLocal and it only used the required jars. cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #59779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59779/consoleFull)** for PR 13428 at commit [`ece86f1`](https://github.com/apache/spark/commit/ece86f1e463707433ccdc34cb5ed10a506da80cb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
