[GitHub] spark issue #13460: [SPARK-15615] [SQL] Support Json input from Dataset[Stri...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13460 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13460: [SPARK-15615] [SQL] Support Json input from Dataset[Stri...
Github user pjfanning commented on the issue: https://github.com/apache/spark/pull/13460 @HyukjinKwon all the JsonSuite tests pass for me on my laptop - would it be feasible to get this reviewed again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13460: [SPARK-15615] [SQL] Support Json input from Dataset[Stri...
Github user pjfanning commented on the issue: https://github.com/apache/spark/pull/13460 @HyukjinKwon this change in input parameter relates to https://github.com/apache/spark/pull/13300. There was a request there to treat Dataset[String] as a preferred input to RDD[String]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13460: [SPARK-15615] [SQL] Support Json input from Dataset[Stri...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13460 I just fetched this PR and run tests. It seems `"SPARK-7565 MapType in JsonRDD"` test is being failed. Maybe this should be solved. Also, if `json(jsonRDD: JavaRDD[String])` is being deprecated, then I think its usages should be changed to the new ones in this PR or in a follow-up. BTW, I guess it is arguable to add a new API. For me, I feel it is a bit questionable to add this API because there is already rdd one, `json(jsonRDD: RDD[String])`. This might be able to be easily down like the blow: ``` json(jsonDataset.rdd) ``` I guess APIs would not be added only for consistency. Maybe I think we should wait for a committer's call. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
