[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user bomeng commented on the issue: https://github.com/apache/spark/pull/13543 @srowen Thanks for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13543 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13543 OK let's go with this. It's basically flip flopping the arguments so that the more natural HOST arg is preferred. Both still work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60182/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60182/consoleFull)** for PR 13543 at commit [`03bb009`](https://github.com/apache/spark/commit/03bb009bab5322b1dc7479aad9267e7d10bd49a7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60182/consoleFull)** for PR 13543 at commit [`03bb009`](https://github.com/apache/spark/commit/03bb009bab5322b1dc7479aad9267e7d10bd49a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13543 More needs to change, like spark-env.sh.template and the scripts in sbin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60146/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60146/consoleFull)** for PR 13543 at commit [`adcaaab`](https://github.com/apache/spark/commit/adcaaab52f711e9c9b0ad2f7fe7db374c7399064). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60146/consoleFull)** for PR 13543 at commit [`adcaaab`](https://github.com/apache/spark/commit/adcaaab52f711e9c9b0ad2f7fe7db374c7399064). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60142/consoleFull)** for PR 13543 at commit [`6f29181`](https://github.com/apache/spark/commit/6f29181d92141db2270a90c2315c0399060bc7d0). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60142/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60142/consoleFull)** for PR 13543 at commit [`6f29181`](https://github.com/apache/spark/commit/6f29181d92141db2270a90c2315c0399060bc7d0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user bomeng commented on the issue: https://github.com/apache/spark/pull/13543 Yes. I can add a warning if SPARK_MASTER_IP is set. Ideally we should use SPARK_MASTER_HOST in all places to avoid confusion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13543 The thing is, `SPARK_MASTER_HOST` is not used anywhere in the code but this file. It's not documented. I would imagine it is the one that's deprecated, but, have a look at https://issues.apache.org/jira/browse/SPARK-3474 In any event, I wonder if we should finally standardize on SPARK_MASTER_HOST? It's as if these two should literally be flipped everywhere in the code, and then this line would generate a warning perhaps if SPARK_MASTER_IP is set? https://github.com/bomeng/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala#L35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user bomeng commented on the issue: https://github.com/apache/spark/pull/13543 Here is the link: [MasterArguments.scala](https://github.com/bomeng/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala#L56-L59) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13543 Pardon, where do you see that SPARK_MASTER_IP is deprecated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user bomeng commented on the issue: https://github.com/apache/spark/pull/13543 Please note that there are also some places still using SPARK_MASTER_IP, for example, start-master.sh, etc. I did not replace them, because it may break the current running script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60130/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13543 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60130/consoleFull)** for PR 13543 at commit [`239cdfc`](https://github.com/apache/spark/commit/239cdfc08e5ad28864574f9ddbcf8240dd5a51ff). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13543: [SPARK-15806] [Documentation] update doc for SPARK_MASTE...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13543 **[Test build #60130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60130/consoleFull)** for PR 13543 at commit [`239cdfc`](https://github.com/apache/spark/commit/239cdfc08e5ad28864574f9ddbcf8240dd5a51ff). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org