[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-12 Thread mhmoudr
Github user mhmoudr commented on the issue:

https://github.com/apache/spark/pull/13588
  
PR #13624 has been created into master branch for the same fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-12 Thread mhmoudr
Github user mhmoudr commented on the issue:

https://github.com/apache/spark/pull/13588
  
Thanks for the reply..
I can still see the same code that cause the problem in master, right now I 
am working on a PR for master that have the fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-12 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/13588
  
@mhmoudr it is just cherry-picked from master back into other branches as 
needed. Is there an existing PR that already fixed this in master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-12 Thread mhmoudr
Github user mhmoudr commented on the issue:

https://github.com/apache/spark/pull/13588
  
I am going to close this PR, but my question is what is the process of 
getting a fix into one of the release branches? as this does not introduce any 
new functionality but just fixes an existing issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-11 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/13588
  
Yeah, you should only open PRs against master in general. You can close 
this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-10 Thread mhmoudr
Github user mhmoudr commented on the issue:

https://github.com/apache/spark/pull/13588
  
This PR contains exactly the same fix but targeting version 1.6 as if there 
is a plan to release 1.6.2 in the future, if that was not the case let me know 
to close it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-10 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/13588
  
@mhmoudr Is this a duplicate of 
[https://github.com/apache/spark/pull/13590]?  Can you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #13588: SPARK-15858: Fix calculating error by tree stack over fl...

2016-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/13588
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org