[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13596 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60339/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60339/consoleFull)** for PR 13596 at commit [`c4c058a`](https://github.com/apache/spark/commit/c4c058aa94e004181413480aefad545b946556d9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60337/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60337/consoleFull)** for PR 13596 at commit [`cf4b6d8`](https://github.com/apache/spark/commit/cf4b6d89657434dc7cc0cda6f84fedeeb2578a7b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60339/consoleFull)** for PR 13596 at commit [`c4c058a`](https://github.com/apache/spark/commit/c4c058aa94e004181413480aefad545b946556d9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13596 LGTM except some minor comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60337/consoleFull)** for PR 13596 at commit [`cf4b6d8`](https://github.com/apache/spark/commit/cf4b6d89657434dc7cc0cda6f84fedeeb2578a7b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/13596 @cloud-fan I modified the test. Please take a look at it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/13596 @cloud-fan Thank you for your review. That's right, so we can't unregister the `batchStats` accumulator here yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13596 My suggestion is: in `InMemoryRelation.uncache`, we set `batchStats` to null at the end, when this `InMemoryRelation` get executed again, it will regenerate the accumulator and register it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13596 The root cause is: even we uncache an `InMemoryRelation`, this `InMemoryRelation` may still get executed. The test case in this PR shows how this happens: 1. we create a DataFrame and cache it 2. execute this DataFrame, to make the analysis, optimization, planning to happen 3. uncahce this DataFrame, however, `QueryExecution` of this df is already generated and won't change 4. execute this DataFrame again, it will still run the previous physical plan and execute an already uncached `InMemoryRelation`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/13596 @rxin @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60291/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60291/consoleFull)** for PR 13596 at commit [`56082d9`](https://github.com/apache/spark/commit/56082d99f63594ca838ebf22131695f4458238e4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13596: [SPARK-15870][SQL] DataFrame can't execute after uncache...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13596 **[Test build #60291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60291/consoleFull)** for PR 13596 at commit [`56082d9`](https://github.com/apache/spark/commit/56082d99f63594ca838ebf22131695f4458238e4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
