[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13636
FYI, this is what I see running on R 3.3:
```
1. Error: string operators (@test_sparkSQL.R#1163)
-
unable to find an inherited method for function âstartsWithâ for
signature â"character"â
1: expect_true(startsWith("Hello World", "Hello")) at
/opt/spark-2.0.0-bin-hadoop2.6/R/lib/SparkR/tests/testthat/test_sparkSQL.R:1163
2: expect(identical(as.vector(object), TRUE), sprintf("%s isn't true.",
lab), info = info)
3: as.expectation(exp, ..., srcref = srcref)
4: identical(as.vector(object), TRUE)
5: as.vector(object)
6: startsWith("Hello World", "Hello")
7: (function (classes, fdef, mtable)
{
methods <- .findInheritedMethods(classes, fdef, mtable)
if (length(methods) == 1L)
return(methods[[1L]])
else if (length(methods) == 0L) {
cnames <- paste0("\"", vapply(classes, as.character, ""), "\"",
collapse = ", ")
stop(gettextf("unable to find an inherited method for function
%s for signature %s",
sQuote(fdef@generic), sQuote(cnames)), domain = NA)
}
else stop("Internal error in finding inherited methods; didn't
return a unique method",
domain = NA)
})(list("character"), structure(function (x, prefix)
{
standardGeneric("startsWith")
}, generic = structure("startsWith", package = "SparkR"), package =
"SparkR", group = list(), valueClass = character(0), signature = c("x",
"prefix"), default = `\001NULL\001`, skeleton = (function (x, prefix)
stop("invalid call in method dispatch to 'startsWith' (no default
method)", domain = NA))(x,
prefix), class = structure("nonstandardGenericFunction", package =
"methods")),
)
8: stop(gettextf("unable to find an inherited method for function %s for
signature %s",
sQuote(fdef@generic), sQuote(cnames)), domain = NA)
```
I will double check if there is indeed a problem with `startsWith("Hello
World", "Hello")` when SparkR is loaded, or the tests are not up-to-date on
what's being masked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13636 @shivaram True. @felixcheung Could you please also add SPARK-15931 to the PR title if this PR also targets that one? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13636 @liancheng we can use this PR to also address https://issues.apache.org/jira/browse/SPARK-15931 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13636 For reference, I was using ``` R version 3.3.0 (2016-05-03) -- "Supposedly Educational" Copyright (C) 2016 The R Foundation for Statistical Computing Platform: x86_64-pc-linux-gnu (64-bit) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13636 I'm still seeing errors after this change in my environment: ``` Failed - 1. Failure: Check masked functions (@test_context.R#31) length(maskedBySparkR) not equal to length(namesOfMasked). 1/1 mismatches [1] 22 - 20 == 2 2. Failure: Check masked functions (@test_context.R#32) sort(maskedBySparkR) not equal to sort(namesOfMasked). Lengths differ: 22 vs 20 DONE === ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13636 great point - @wangmiao1981 it looks like `startsWith` and `endsWith` are still masked on R 3.3? re: PR #13476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13636 LGTM. Just to confirm your local tests pass with R version > 3.2 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60386/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13636 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13636 **[Test build #60386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60386/consoleFull)** for PR 13636 at commit [`a5eb3da`](https://github.com/apache/spark/commit/a5eb3daeb1d34e082e22176fd272dbe49398aaa8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13636: [SPARK-15637][SPARKR] Remove R version check since maske...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13636 **[Test build #60386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60386/consoleFull)** for PR 13636 at commit [`a5eb3da`](https://github.com/apache/spark/commit/a5eb3daeb1d34e082e22176fd272dbe49398aaa8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
