[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Sure! Thank you for review and discussion, @HyukjinKwon , @srowen , @mengxr , and @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13915 Can you close this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Anyway, it was interesting issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Oh, I see. Then, please close the issue as 'Won't Fix'. I'll close this PR, then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13915 I think it's a weird way to track it -- maybe it's not worth doing at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 If so, what about just adding new ScalaStyle with 90 exclusion files? In this case, we don't need to touch any Scala codes. That seems enough for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13915 BTW it is not just I. It's also the number "1" that can get mixed up with l. I don't think we need a rule to exclude "I", since nobody uses a single capital I as identifier. So perhaps we can just fix a few places that is clearly problematic and call it a day. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Hi, All. The decision points are the followings. 1. Choose one of lowercase `L` or uppercase `I` to disallow as a ScalaStyle. 2. Choose a scope of ScalaStyle excluded files: * 0: Fix everything and clean the code at this time. * 0 < .. < 90: Fix some modules. * 90: Allow all existing code and prevent further occurrence in other files. Currently, this PR is choosing lowercase 'L' and 0 excluded files. Any advice? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 @mengxr 's idea sounds good to me, too. May I update this PR, @rxin ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13915 yea I think you can argue this should be discouraged but not necessarily justify banning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13915 @dongjoon-hyun @rxin Is it necessary? `l` and `I` are similar but different in most monospace fonts. Instead of banning `l`, we should ban using `I` as the variable name, which is less often. `l` is used quite frequently as a variable name in math (length, dimensions, nested loops). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Hi, @rxin and @srowen . I also worry about merge conflicts. It's really annoying for committers. So, what about the stepwise approach? We have 2395 files and found 90 files having violation. If we adds a ScalyStyle rule and excludes those 90 files in this PR, we still can prevent 2305 files from future violations. We can remove the exclusion according to the evolution of those 90 files. Of course, some fixes of this PR can be applied adaptively for **testing** modules or **example** modules. Please give me some advices. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61297/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61297/consoleFull)** for PR 13915 at commit [`f58b7b7`](https://github.com/apache/spark/commit/f58b7b7db4f859d6c1f673f50ba360a0175bad69). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61299/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61299/consoleFull)** for PR 13915 at commit [`4134deb`](https://github.com/apache/spark/commit/4134deb036e632ebb2d9ac0f49f2c0cd708dfd22). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61297/consoleFull)** for PR 13915 at commit [`f58b7b7`](https://github.com/apache/spark/commit/f58b7b7db4f859d6c1f673f50ba360a0175bad69). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61299/consoleFull)** for PR 13915 at commit [`4134deb`](https://github.com/apache/spark/commit/4134deb036e632ebb2d9ac0f49f2c0cd708dfd22). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 For the `case l: Long`, now I tried to use `case i: Long` since `Long` is generally considered as `Integer`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Thank you for review, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13915 It's a lot of change, and that's the only drawback -- might add to the number of merge conflicts between 2.1 and earlier versions if it's merged to master. Still, overall I do like the improved style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 cc @rxin and @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13915 Thank you, @HyukjinKwon . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61279/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61279/consoleFull)** for PR 13915 at commit [`819b0d2`](https://github.com/apache/spark/commit/819b0d246c13ef5cfa199d73aa14a86b5e5a42fc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13915 Oh, this was queued up in my local to submit a PR. I will leave a comment just to note that this complies https://github.com/databricks/scala-style-guide#variable-naming-convention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61278/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61278/consoleFull)** for PR 13915 at commit [`a3a020d`](https://github.com/apache/spark/commit/a3a020d2c389cacc5fa3eb11880d7fa8c529d309). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61279/consoleFull)** for PR 13915 at commit [`819b0d2`](https://github.com/apache/spark/commit/819b0d246c13ef5cfa199d73aa14a86b5e5a42fc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61276/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61276/consoleFull)** for PR 13915 at commit [`b31496d`](https://github.com/apache/spark/commit/b31496d89983017a2fe6d774ced967d186a8da32). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61278/consoleFull)** for PR 13915 at commit [`a3a020d`](https://github.com/apache/spark/commit/a3a020d2c389cacc5fa3eb11880d7fa8c529d309). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61276/consoleFull)** for PR 13915 at commit [`b31496d`](https://github.com/apache/spark/commit/b31496d89983017a2fe6d774ced967d186a8da32). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61275/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61275/consoleFull)** for PR 13915 at commit [`0d40e54`](https://github.com/apache/spark/commit/0d40e542499ab25756b6a16e9d42ab1869ab9693). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61275/consoleFull)** for PR 13915 at commit [`0d40e54`](https://github.com/apache/spark/commit/0d40e542499ab25756b6a16e9d42ab1869ab9693). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61274/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61274/consoleFull)** for PR 13915 at commit [`8be1263`](https://github.com/apache/spark/commit/8be126351975a288e7cc918e5008eefa957ae29f). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13915: [SPARK-16081][BUILD] Disallow using `l` as variable name
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13915 **[Test build #61274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61274/consoleFull)** for PR 13915 at commit [`8be1263`](https://github.com/apache/spark/commit/8be126351975a288e7cc918e5008eefa957ae29f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
