[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14048 A more fruitful approach might be to introduce a separate operator for multi-insert. Lets leave that for another day :)... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Hmm. Okay, I didn't prevent all. I see. I'll close. Thank you for decision, @cloud-fan . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14048 ``` case Union(children) if children.forall(x => x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]) => ``` This doesn't indicate a muliti-insert right? A normal `Uion` can also looks like this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Ah, I see. You mean Union of `INSERT INTO`s, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 This PR fixes that with minimal efforts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Ur, what do you mean? > With your patch, we can still create union queries with side effect which will be executed eagerly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 The current one looks like this. ``` case Union(children) if children.forall(x => x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]) => ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14048 It's good to elimiante the inconsistency, but I don't think there is an easy fix. With your patch, we can still create union queries with side effect which will be executed eagerly. We use `Union` to implement multi-insert, so there is no way to distinguish them at plan level, except we do some fundamental changes. As this is a small issue, I don't think it worth a lof of effort to fix it. How about we close this PR for now and think about a holistic fix if users complain about it? thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Hi, @cloud-fan . Could you think about this one more time please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61989/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61989/consoleFull)** for PR 14048 at commit [`f14cb78`](https://github.com/apache/spark/commit/f14cb787b7579e92a002f07029064b984068f416). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61989/consoleFull)** for PR 14048 at commit [`f14cb78`](https://github.com/apache/spark/commit/f14cb787b7579e92a002f07029064b984068f416). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61978/consoleFull)** for PR 14048 at commit [`f14cb78`](https://github.com/apache/spark/commit/f14cb787b7579e92a002f07029064b984068f416). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61978/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Rebased and PR description is updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61978/consoleFull)** for PR 14048 at commit [`f14cb78`](https://github.com/apache/spark/commit/f14cb787b7579e92a002f07029064b984068f416). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61791/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61791/consoleFull)** for PR 14048 at commit [`b035865`](https://github.com/apache/spark/commit/b035865cf0f90e44f94af69956d8d87239365748). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61791/consoleFull)** for PR 14048 at commit [`b035865`](https://github.com/apache/spark/commit/b035865cf0f90e44f94af69956d8d87239365748). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61779/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61779/consoleFull)** for PR 14048 at commit [`e497bd7`](https://github.com/apache/spark/commit/e497bd7aff58f5da363ad4dff81596bc63395bd7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61779/consoleFull)** for PR 14048 at commit [`e497bd7`](https://github.com/apache/spark/commit/e497bd7aff58f5da363ad4dff81596bc63395bd7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14048 **[Test build #61776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61776/consoleFull)** for PR 14048 at commit [`b55a757`](https://github.com/apache/spark/commit/b55a757e9d217107687e96238bd860bca3d8db4b). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61776/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14048 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
