[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 @rxin Thank you for mentioning that. I even didn't notice that. Haha. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14080 @lovexi you should add your commit email to your github profile, so the commit will show proper attribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14080 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3185/consoleFull)** for PR 14080 at commit [`4884084`](https://github.com/apache/spark/commit/488408479858b026cf67d9a04e7b0fe1aad8934d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 Thank you for reminding me this. Already updated PR description and add more details. cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3185 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3185/consoleFull)** for PR 14080 at commit [`4884084`](https://github.com/apache/spark/commit/488408479858b026cf67d9a04e7b0fe1aad8934d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14080 Can you update the pull request description? It is now outdated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 Restart test, please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 @rxin Thank you for letting me know this. That saves me a lot of time on testing.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14080 There is a test failure ``` [error] Test org.apache.spark.network.sasl.SaslIntegrationSuite.testAppIsolation failed: java.lang.RuntimeException: java.lang.NullPointerException [error] at org.apache.spark.network.shuffle.ExternalShuffleBlockHandler.handleMessage(ExternalShuffleBlockHandler.java:100) [error] at org.apache.spark.network.shuffle.ExternalShuffleBlockHandler.receive(ExternalShuffleBlockHandler.java:83) [error] at org.apache.spark.network.sasl.SaslRpcHandler.receive(SaslRpcHandler.java:80) [error] at org.apache.spark.network.server.TransportRequestHandler.processRpcRequest(TransportRequestHandler.java:158) [error] at org.apache.spark.network.server.TransportRequestHandler.handle(TransportRequestHandler.java:106) [error] at org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:119) [error] at org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:51) [error] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at org.apache.spark.network.util.TransportFrameDecoder.channelRead(TransportFrameDecoder.java:85) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846) [error] at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) [error] at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511) [error] at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468) [error] at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382) [error] at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354) [error] at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111) [error] at java.lang.Thread.run(Thread.java:745) [error] , took 0.073 sec [error] at org.apache.spark.network.client.TransportResponseHandler.handle(TransportResponseHandler.java:190) [error] at org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:121) [error] at org.apache.spark.network.server.TransportChannelHandler.channelRead0(TransportChannelHandler.java:51) [error] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [error] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [error] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [error] at org.apache.spark.network.util.TransportFrameDecoder.channelRead(TransportFrameDecoder.java:85) [error] at
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3182/consoleFull)** for PR 14080 at commit [`258ed7a`](https://github.com/apache/spark/commit/258ed7a56fdc0bdce4f93de0e58e2c37b08f7e86). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3182 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3182/consoleFull)** for PR 14080 at commit [`258ed7a`](https://github.com/apache/spark/commit/258ed7a56fdc0bdce4f93de0e58e2c37b08f7e86). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 test this, please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3181/consoleFull)** for PR 14080 at commit [`9ca99bb`](https://github.com/apache/spark/commit/9ca99bbeee8cac6d21b7888571f2c9ab7b51c453). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3181 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3181/consoleFull)** for PR 14080 at commit [`9ca99bb`](https://github.com/apache/spark/commit/9ca99bbeee8cac6d21b7888571f2c9ab7b51c453). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 test it, please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3180/consoleFull)** for PR 14080 at commit [`95a864c`](https://github.com/apache/spark/commit/95a864cfd1ca6df8d6c83e9c2968ceacc7b592d4). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14080 **[Test build #3180 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3180/consoleFull)** for PR 14080 at commit [`95a864c`](https://github.com/apache/spark/commit/95a864cfd1ca6df8d6c83e9c2968ceacc7b592d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14080 Thanks, this LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 Added some test cases to verify expected metrics values @ericl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14080 Thanks for adding these metrics. Could you also add some unit tests to sanity check these metrics are recorded as expected, e.g. as in https://github.com/apache/spark/pull/13934/files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14080: [SPARK-16405] Add metrics and source for external shuffl...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14080 @rxin Sure. Get a cleaner title instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
