[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14167 great thnx @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14167 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14167 @andrewor14 @srowen pls merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62635/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62635/consoleFull)** for PR 14167 at commit [`1824d63`](https://github.com/apache/spark/commit/1824d63c04b63c8392708746bd22f4a8662b5e78). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62629/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62629/consoleFull)** for PR 14167 at commit [`b9c396b`](https://github.com/apache/spark/commit/b9c396b4bfd01313af9f728035e1093c66a9016a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62635/consoleFull)** for PR 14167 at commit [`1824d63`](https://github.com/apache/spark/commit/1824d63c04b63c8392708746bd22f4a8662b5e78). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62629/consoleFull)** for PR 14167 at commit [`b9c396b`](https://github.com/apache/spark/commit/b9c396b4bfd01313af9f728035e1093c66a9016a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 Updated the description and added docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14167 LGTM. I agree with @viirya for the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14167 nit: From the code, it is `spark.mesos.driverEnv` but in PR description it is `spark.mesos.env`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14167 I don't know anything about mesos, but I presume y'all are pretty expert. Unless anyone else with Mesos knowledge chimes in, and tests pass and all that, OK to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 @srowen Can we get a merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62391/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62391 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62391/consoleFull)** for PR 14167 at commit [`de75386`](https://github.com/apache/spark/commit/de7538616e63d8a80aac0814a1c7133989e61817). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62391/consoleFull)** for PR 14167 at commit [`de75386`](https://github.com/apache/spark/commit/de7538616e63d8a80aac0814a1c7133989e61817). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 @skonto fixed the style issues @andrewor14 plz merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14167 LGTM other than minor style issues. I run our tests against it so refactoring is successful i guess. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62340/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62340/consoleFull)** for PR 14167 at commit [`9f7b151`](https://github.com/apache/spark/commit/9f7b15198f8834334cac09b0a76cda649081bbd2). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14167 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62341/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62341/consoleFull)** for PR 14167 at commit [`1bfee1d`](https://github.com/apache/spark/commit/1bfee1dd8546eba5c19a8a2fe08a95650de219f1). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62341/consoleFull)** for PR 14167 at commit [`1bfee1d`](https://github.com/apache/spark/commit/1bfee1dd8546eba5c19a8a2fe08a95650de219f1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14167 **[Test build #62340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62340/consoleFull)** for PR 14167 at commit [`9f7b151`](https://github.com/apache/spark/commit/9f7b15198f8834334cac09b0a76cda649081bbd2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 Note that I'll add docs once the code is :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 @skonto comments addressed. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14167 The build fails with: [error] /home/jenkins/workspace/SparkPullRequestBuilder@4/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala:34: object Utils is not a member of package org.apache.spark.scheduler.cluster.mesos [error] import org.apache.spark.scheduler.cluster.mesos.Utils._ https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62270/consoleFull I reproduce it locally you are missing the Utils object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14167: [SPARK-16194] Mesos Driver env vars
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14167 Error message from build: `ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
