[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/14219 SparseVector indices are assumed to be sorted already. We should not re-sort them during operations. The deeper issue which needs to be fixed is SPARK-14707 I commented in the JIRA as well. Could you please close this issue? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 Modifications also needed on module mllib-local, file org.apache.spark.ml.linalg.Vectors.scala. Once the changes is okay, I will also apply the changes there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 @hhbyyh I just checked, the implementation of `def dot(x: SparseVector, y: SparseVector)` also need to be modified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user wilson-lauw commented on the issue: https://github.com/apache/spark/pull/14219 file org.apache.spark.ml.linalg.BLAS.scala on module mllib-local also need to be fixed, once the changes is okay, I will also apply the changes there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/14219 Order of the indices in SparseVector potentially affects many other BLAS operations. Perhaps we should have it in a more general/reusable pattern if we do want to impose the validation. Yet the most efficient way as I see is still to perform the check during construction, maybe something like an optional `validate` parameter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14219: [SPARK-16566][MLLib] sort sparseVector's indices before ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14219 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
