[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14223 @vanzin I didn't mean closing the JIRA ticket. Let's just close this stale PR since it doesn't have the correct fix. We can always submit a new PR if necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14223 I don't think closing this PR is the right thing to do. This solves an actual problem, in that we have code that depends on the clock being monotonic, but a non-monotonic clock is being used. If there's a need to differentiate that from actual system time, then perhaps we need to extend the `Clock` API. But there's an actual issue that this change is fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14223 > This method can only be used to measure elapsed time and is not related to any other notion of system or wall-clock time. The value returned represents nanoseconds since some fixed but arbitrary origin time (perhaps in the future, so values may be negative). The same origin is used by all invocations of this method in an instance of a Java virtual machine; other virtual machine instances are likely to use a different origin. As per javadoc, `System.nanoTime` cannot be used to get the current system time. I saw most of places just use `getTimeMillis` to get the current system time and display it on UI. I don't think we can change it to `System.nanoTime`. @markgrover could you close this pr, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/14223 And, thanks for your feedback, @rxin, I will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/14223 Thanks @vanzin Yeah, I noticed that too. Will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14223 @markgrover these two tests fail consistently just on your PR, so it looks like they're not as unrelated as you thought. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62421/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14223 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62399/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62399/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62399/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14223 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62395/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14223 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62395/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14223 **[Test build #62395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62395/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Github user markgrover commented on the issue: https://github.com/apache/spark/pull/14223 The unit test failures from the previous run looked unrelated, fyi. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
