[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14258 Thanks @junyangq and @felixcheung -- LGTM. Merging this to master and branch-2.0 We should add some tests to this and enable the checks to run on every PR. But we can do this as a part of SPARK-16577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14258 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14258 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63456/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14258 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14258 **[Test build #63456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63456/consoleFull)** for PR 14258 at commit [`3aeb4eb`](https://github.com/apache/spark/commit/3aeb4ebe7b18f5b26914cdf730cced3eb536f48d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14258 **[Test build #63456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63456/consoleFull)** for PR 14258 at commit [`3aeb4eb`](https://github.com/apache/spark/commit/3aeb4ebe7b18f5b26914cdf730cced3eb536f48d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14258 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63455/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14258 **[Test build #63455 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63455/consoleFull)** for PR 14258 at commit [`d84ba06`](https://github.com/apache/spark/commit/d84ba062b752f9987a1e8be28de5edd6c57c7a8b). * This patch **fails R style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14258 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14258 **[Test build #63455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63455/consoleFull)** for PR 14258 at commit [`d84ba06`](https://github.com/apache/spark/commit/d84ba062b752f9987a1e8be28de5edd6c57c7a8b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14258 I think we should go ahead with this and get some usage from the community if we could as early as possible. LGTM - we could see if we could improve on how to detect if running from shell later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14258 Sounds good to me. It doesn't fail tests except for the cran one if you delete `--no-test`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14258 I see - So I was thinking that we could merge this into master as well as its not going to fail any tests or affect any users building SparkR from source -- I dont think we make any promises about the master branch to users. As long as the same code works in branch-2.0 then we can just backport this (if we do want a separate PR for branch-2.0 thats fine, but its just easier to keep all the code review on one PR) @felixcheung @mengxr Any other comments on this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14258 @shivaram There is only one additional minor change there. The reason I opened #14448 on branch-2.0 is because we download the 2.0 jars, and there are some api changes from 2.0 to current master (e.g. `showString`), so I guess it would cause some problem if we use the master R code with 2.0 jars. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14258 @junyangq Is #14448 different from this PR or is it the same one on branch-2.0 ? I can just merge this into two branches, so we dont need a new PR I think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14258 @felixcheung Sorry I still didn't get there. It seems that internally it checks via `args.primaryResource`. I was wondering if there is a good way to access to that in sparkR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14258: [Spark-16579][SparkR] add install.spark function
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14258 For my comment on https://github.com/apache/spark/pull/14258#discussion_r72683426 Like this: https://github.com/apache/spark/blob/fa4bc8ea8bab1277d1482da370dac79947cac719/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
