[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14320 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62765/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14320 **[Test build #62765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62765/consoleFull)** for PR 14320 at commit [`334adaf`](https://github.com/apache/spark/commit/334adafa85dd1dca5485ccbbe7a17645c12fc52f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14320 **[Test build #62765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62765/consoleFull)** for PR 14320 at commit [`334adaf`](https://github.com/apache/spark/commit/334adafa85dd1dca5485ccbbe7a17645c12fc52f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14320 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14320 OK, seems reasonable to me as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user mikaelstaldal commented on the issue: https://github.com/apache/spark/pull/14320 I realized that it is necessary everywhere where you register a shutdown hook, if you log from within the shutdown hook. Another way to solve it would be to refrain to log from within shutdown hooks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14320 Should just be necessary in the ShutdownHookManager? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user mikaelstaldal commented on the issue: https://github.com/apache/spark/pull/14320 It is, I just had to apply the same in several places. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14320 This doesn't seem to be the change discussed in the JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14320 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
