[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14400 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63076/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14400 **[Test build #63076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63076/consoleFull)** for PR 14400 at commit [`e0549a9`](https://github.com/apache/spark/commit/e0549a998f3d75eeedf4334e9d61ad57dbe52efe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14400 we have an individual style check script: `./dev/scalastyle` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/14400 @cloud-fan, just for notice for the next patches: is there a way to run mvn in a mode that fails on style issues? it could save a lot of round-trips if it existed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14400 **[Test build #63076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63076/consoleFull)** for PR 14400 at commit [`e0549a9`](https://github.com/apache/spark/commit/e0549a998f3d75eeedf4334e9d61ad57dbe52efe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14400 https://github.com/apache/spark/pull/14400#discussion_r72897142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/14400 @cloud-fan, any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63052/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14400 **[Test build #63052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63052/consoleFull)** for PR 14400 at commit [`6e7f69f`](https://github.com/apache/spark/commit/6e7f69f11e02632837e97c428e39ae3de0926e7b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14400 **[Test build #63052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63052/consoleFull)** for PR 14400 at commit [`6e7f69f`](https://github.com/apache/spark/commit/6e7f69f11e02632837e97c428e39ae3de0926e7b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14400 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14400 Good catch! LGTM except the style comment given by @ueshin . And please also use full word for variable name, e.g. `originalSchema`, `targetSchema` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/14400 Good catch! I have some comments, please check them. /cc @marmbrus @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/14400 @ueshin , you seem to be the original committer of this code. can you please have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14400: [Spark-16791] [SQL] cast struct with timestamp field fai...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14400 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
