[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14415 Oops. I kind of messed up here. Going to open another PR for this. Close this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14415 @rxin I was trying to add a unit test for this feature. But the test sinks are not visible for `MetricsSystem` when it tries to register test sink classes since test sinks are hidden in test packages. Is there any other ways to load test classes for `MetricsSystem` without messed-up metrics package? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14415 DId you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14415 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
