[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14428 Reopen PR #14415 @rxin >> DId you add a test? I was trying to add a unit test for this feature. But the test sinks are not visible for MetricsSystem when it tries to register test sink classes since test sinks are hidden in test packages. Is there any other ways to load test classes for MetricsSystem without messed-up metrics package? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14428 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14428 They should be visible in test scope, shouldn't they? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14428 Oh, my bad. Added unit test in `MetricsSystemSuite ` for this already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14428 I think this one is ready for reviews. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14428 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14428 **[Test build #63236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63236/consoleFull)** for PR 14428 at commit [`c9d497b`](https://github.com/apache/spark/commit/c9d497bdd7db8a467d9328db93fec7316714870b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14428 **[Test build #63236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63236/consoleFull)** for PR 14428 at commit [`c9d497b`](https://github.com/apache/spark/commit/c9d497bdd7db8a467d9328db93fec7316714870b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14428 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63236/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14428 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/14428 Are you still working on this @lovexi ? Or should we temporarily close the PR if you happen to don't have time for now? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
