[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14468 Given the overwhelming amount of feedback, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14468 Friendly ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63187/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63187/consoleFull)** for PR 14468 at commit [`eba7c6d`](https://github.com/apache/spark/commit/eba7c6d8f6558e15a7d34edd7bb9a5a8e86699c9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14468 @rxin want to take a look since you added `VariableSubstitution`? Also @srowen since he looked at my previous patch. The depth config is not used anymore but I don't know if it's kosher to remove SQLConf constants; I saw some asserts in the code that I assume might be triggered by users. Also I assume that the circular reference check is enough so we don't need the depth check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63187/consoleFull)** for PR 14468 at commit [`eba7c6d`](https://github.com/apache/spark/commit/eba7c6d8f6558e15a7d34edd7bb9a5a8e86699c9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63179/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63179/consoleFull)** for PR 14468 at commit [`290c964`](https://github.com/apache/spark/commit/290c96407195a8230912dfa8442a8d301727853d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63179/consoleFull)** for PR 14468 at commit [`290c964`](https://github.com/apache/spark/commit/290c96407195a8230912dfa8442a8d301727853d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63142/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63142/consoleFull)** for PR 14468 at commit [`9d88d87`](https://github.com/apache/spark/commit/9d88d871538a577ddab439858e1fc016c8737f09). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class ConfigReader(conf: ConfigProvider) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14468: [SPARK-16671][core][sql] Consolidate code to do variable...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14468 **[Test build #63142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63142/consoleFull)** for PR 14468 at commit [`9d88d87`](https://github.com/apache/spark/commit/9d88d871538a577ddab439858e1fc016c8737f09). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
