[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user ChinaChaos commented on the issue:
https://github.com/apache/spark/pull/14577
HI @Sherry302 , @srowen , @rxin
this patch will make the UI not compatible with Firefox and safari;
Started time, Completed time,Last Updated time cant display
rightï¼just like that:
NAN-NAN-NAN NAN:NAN:NAN
how to sovle this problem
var localDate = new Date((date.split(".")[0].replace("T", " ")+ "
UTC").replace(/-/g,"/"));
return localDate.getFullYear() + "/" + padLeft(localDate.getMonth() +
1) + "/"
+ padLeft(localDate.getDate()) + " " +
padLeft(localDate.getHours()) + ":"
+ padLeft(localDate.getMinutes()) + ":" +
padLeft(localDate.getSeconds());
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14577 I think we should not make this particular change and can close this PR. It's possible another similar change could be OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/14577 Hi, @srowen Thanks a lot for the comments. Sorry for the late reply. You are right. I will check how other pages format the date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14577 Hm, I also don't quite like this change, as it's kind of hackily rewriting dates in Javascript. I am not sure this is correct, even. What does the Spark job page do to format dates? Seems like it should format dates, and format them in the same way the cluster would internally in other logs and information presentation, which would probably be the server's time zone. At least, that would surprise me less than putting it in my local time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user Sherry302 commented on the issue: https://github.com/apache/spark/pull/14577 Hi, @rxin . Thanks for the quick feedback. This PR is to remove time inconsistency between webpages. Right now the times in history page is inconsistent with the times in other pages like spark job pages, that makes users confused. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14577 So this change can be really annoying in debugging, when we try to correlate time shown on the UI with time in logs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14577: [SPARK-16986][WEB UI] Make 'Started' time, 'Completed' t...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14577 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
