[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14637 @srowen OK, added the profile to: - .travis.yml - release-build.sh - lint-java - mima - scalastyle What about dev/test-dependencies.sh. Also, I added mesos to PUBLISH_PROFILES in release-build.sh. Should I also add it to the make_binary_release profiles? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14637 Good call, I think it's dev/sparktests/modules.py that needs to be modified. it can clone YARN's config. I assume that the release binaries will have this profile activated as with YARN. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14637 Also, with the current changes, doesn't it mean the PR builder is not building the mesos code? Shouldn't you modify `dev/run-tests.py` (I think that's the right place)? The modification to the dependency files also raises another question: how will this be made available to users? Will there be a new package "spark-with-mesos" that needs to be packaged separately? Will users add it with "--packages" instead? There might be changes needed to `dev/create-release/release-build.sh` depending on the answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14637 If this is ready for review could you remove "wip" from the pr title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14637 You can ignore the MiMa error and suppress it, yes. This is generally looking great, thanks. @vanzin would be a good reviewer too. I think we'll have to change the Jenkins job config later to set `-Pmesos` -- will see about it. There are some other miscellaneous places that may need to add the new profile, `dev/`: - `lint-java`, `scalastyle` - `mima` add to the profiles it uses for MiMa - `create-release/release-build.sh` I assume the default tarballs will still build in Mesos Although it's kind of dead config, you might add the profile to `.travis.yml` too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14637 mima seems to be upset about my removal of MESOS_REGEX from `SparkMasterRegex`, but I don't understand why, as it's a private class. Should I add an entry to MimaExcludes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #64109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64109/consoleFull)** for PR 14637 at commit [`95e473b`](https://github.com/apache/spark/commit/95e473ba046298d5669dfe63264fc139d600b787). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64109/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #64109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64109/consoleFull)** for PR 14637 at commit [`95e473b`](https://github.com/apache/spark/commit/95e473ba046298d5669dfe63264fc139d600b787). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/14637 @srowen Ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14637 Directionally this is looking spot on, thank you. Ping when you want a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63765/consoleFull)** for PR 14637 at commit [`4e276ab`](https://github.com/apache/spark/commit/4e276ab81848669ec5c7da6d51cf63a46b1bac87). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63765/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63765/consoleFull)** for PR 14637 at commit [`4e276ab`](https://github.com/apache/spark/commit/4e276ab81848669ec5c7da6d51cf63a46b1bac87). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63754/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63754 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63754/consoleFull)** for PR 14637 at commit [`465929e`](https://github.com/apache/spark/commit/465929e41a89941dbf5060b68d1c15958df4af91). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63753/consoleFull)** for PR 14637 at commit [`57a191b`](https://github.com/apache/spark/commit/57a191bc6b046d68ed1ed9dde8b5c52710fdf214). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63753/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14637 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63754/consoleFull)** for PR 14637 at commit [`465929e`](https://github.com/apache/spark/commit/465929e41a89941dbf5060b68d1c15958df4af91). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14637: [WIP] [SPARK-16967] move mesos to module
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14637 **[Test build #63753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63753/consoleFull)** for PR 14637 at commit [`57a191b`](https://github.com/apache/spark/commit/57a191bc6b046d68ed1ed9dde8b5c52710fdf214). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
