[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14763 LGTM - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64295/consoleFull)** for PR 14763 at commit [`fdec971`](https://github.com/apache/spark/commit/fdec9711b657ede82ab985d71b70f00349d75566). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14763 Good for you! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14763 Thanks @dongjoon-hyun for the pointer; I've regenerated the answer set and all tests are now passing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64295/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64295/consoleFull)** for PR 14763 at commit [`fdec971`](https://github.com/apache/spark/commit/fdec9711b657ede82ab985d71b70f00349d75566). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14763 Hi, @JoshRosen . The generated SQL seems to be changed. In order to pass `LogicalPlanToSQLSuite`, you can regenerate the answer set with the following command. ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "hive/test-only *LogicalPlanToSQLSuite" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64257/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64257/consoleFull)** for PR 14763 at commit [`9076cbe`](https://github.com/apache/spark/commit/9076cbeafef8d699562d09b0fea6b0be1eed3535). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64257/consoleFull)** for PR 14763 at commit [`9076cbe`](https://github.com/apache/spark/commit/9076cbeafef8d699562d09b0fea6b0be1eed3535). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14763 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14763 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64246/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64246/consoleFull)** for PR 14763 at commit [`9076cbe`](https://github.com/apache/spark/commit/9076cbeafef8d699562d09b0fea6b0be1eed3535). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14763: [SPARK-17194] Use single quotes when generating SQL for ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14763 **[Test build #64246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64246/consoleFull)** for PR 14763 at commit [`9076cbe`](https://github.com/apache/spark/commit/9076cbeafef8d699562d09b0fea6b0be1eed3535). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
