[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14777 LGTM - merging to master/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14777 Actually I think this is fine; my confusion stemmed from SQL dialect-specific issues related to the name of the double type, which in many databases is `DOUBLE PRECISION` (which isn't recognized by Spark). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14777 Don't merge this yet; may have found more decimal bugs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64320/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14777 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14777 **[Test build #64320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64320/consoleFull)** for PR 14777 at commit [`26e036a`](https://github.com/apache/spark/commit/26e036af512e7e21a1365cdf665cb5e9dca39c66). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14777: [SPARK-17205] Literal.sql should handle Infinity and NaN
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14777 **[Test build #64320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64320/consoleFull)** for PR 14777 at commit [`26e036a`](https://github.com/apache/spark/commit/26e036af512e7e21a1365cdf665cb5e9dca39c66). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
