[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14798 @zsxwing PR #14811 is a backport of this PR to `branch-2.0`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14798 Will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14798 @mallman It has some conflicts with 2.0. Could you submit another PR for branch 2.0, please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/14798 LGTM. I was just thinking to work on this yesterday! Thanks, merging to master and 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14798 I focused mainly on trace and debug logging. I didn't do much with errors or warnings, especially where exceptions are logged. I'm assuming these are less frequent, and the cost of building those log messages is insignificant compared to the circumstances which called for them in the first place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14798
Seems fine to me. I think you'd be welcome to fix up the other log messages
you see in these files to use {} placeholders, but that's entirely optional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14798 Ah the unfortunate thing about Java without macros or call by name. cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14798 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64383/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14798 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14798 **[Test build #64383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64383/consoleFull)** for PR 14798 at commit [`82ba6f9`](https://github.com/apache/spark/commit/82ba6f9002aaa169830335441c4b4ddbcc43a868). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14798: [SPARK-17231][CORE] Avoid building debug or trace log me...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14798 **[Test build #64383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64383/consoleFull)** for PR 14798 at commit [`82ba6f9`](https://github.com/apache/spark/commit/82ba6f9002aaa169830335441c4b4ddbcc43a868). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
