[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15393 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66540/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66540/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66540/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15393 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66530/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66530/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66519/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66519/consoleFull)** for PR 15393 at commit [`83df63b`](https://github.com/apache/spark/commit/83df63b1303ee41838b3524737ce53ee2ac5e17f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66521/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15393 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15393 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66530/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15393 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66521/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15393 Yep. I knew. What I'm asking is we don't need to explain 'contains' usage here in this PR. I prefer not to advertise `contains` for `Option[Boolean]`. ``` scala> val o: Option[Boolean] = None o: Option[Boolean] = None scala> o.contains(false) res17: Boolean = false scala> val o: Option[Boolean] = Some(true) o: Option[Boolean] = Some(true) scala> o.contains(false) res18: Boolean = false scala> val o: Option[Boolean] = Some(false) o: Option[Boolean] = Some(false) scala> o.contains(false) res19: Boolean = true ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15393 @dongjoon-hyun I already did :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15393 BTW, could you update the PR description, @HyukjinKwon ? Maybe, removing `exists` part? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15393 I apologize and will definitely be careful as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15393 Actually, I hit this before. Sorry, I did not catch it when I merging the PR. Next time, I will be more careful about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15393 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66521/consoleFull)** for PR 15393 at commit [`d052ab6`](https://github.com/apache/spark/commit/d052ab663e0b6c246070e7dd2d4728a9708c8ac9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15393 **[Test build #66519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66519/consoleFull)** for PR 15393 at commit [`83df63b`](https://github.com/apache/spark/commit/83df63b1303ee41838b3524737ce53ee2ac5e17f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15393: [HOTFIX][BUILD] Do not use contains in Option in JdbcRel...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15393 @yhuai @zsxwing Do you mind if I ask to take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
